feat: eip-7702 support in aa-sdk/core, and sma7702 support in account-kit/smart-contracts #1287
Conversation
adamegyed
requested review from
moldy530,
rthomare,
dancoombs,
mokok123,
dphilipson,
linnall,
howydev,
Zer0dot,
jaypaik,
Blu-J,
noam-alchemy and
jakehobbs
as code owners
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
How to use the Graphite Merge QueueAdd the label graphite-merge-queue to this PR to add it to the merge queue. You must have a Graphite account in order to use the merge queue. Sign up using this link. An organization admin has enabled the Graphite Merge Queue in this repository. Please do not merge from GitHub as this will restart CI on PRs being processed by the merge queue. |
adamegyed
changed the title
adamegyed
force-pushed
the
adam/7702-core
branch
from
6797694 to
ed436d8
Compare
There was a problem hiding this comment.
this is looking good!
One thing missing is some client.test at a minimum (though would be great if we could extend it to installValidation.ts and have unit tests for installValidation.test.ts)
OOS for this PR is the naming I think, but calling it out here as @howydev and @linnall look at consolidating to the Prism naming as just looking at this PR it's clear that it'll be much better devex externally to have both a Prism account factory and Prism client factory for release
|
|
||
| export type MAV2Account< | ||
| TSigner extends SmartAccountSigner = SmartAccountSigner | ||
| > = SmartContractAccountWithSigner<"MAV2Account", TSigner, "0.7.0"> & { |
There was a problem hiding this comment.
I think this base type should probably be generic on source as well since source should be unique per instance (ie. the first generic parameter in SmartContractAccountWithSigner)
| signer: TSigner; | ||
| entryPoint?: EntryPointDef<"0.7.0", Chain>; | ||
| signerEntity?: SignerEntity; |
There was a problem hiding this comment.
oh yea I remember seeing this during hackathon and thinking it odd. Why can't we merge signer and signerEntity?
account-kit/smart-contracts/src/ma-v2/account/semiModularAccount7702.ts
Outdated
Show resolved
Hide resolved
site/pages/reference/account-kit/infra/functions/alchemyGasManagerMiddleware.mdx
Outdated
Show resolved
Hide resolved
adamegyed
force-pushed
the
adam/7702-core
branch
from
c0d52b7 to
847ab00
Compare
* feat: adds initial impl of signAuthorization * docs: adds signAuthorization documentation * fix: rename var
* feat: add unified ma v2 client * chore: update docs * chore: make account source unique
* feat: add unified ma v2 client * chore: make account source unique * feat: add ma v2 account to use smart contract client hook * chore: remove different type names * chore: rename mav2 to ModularAccountV2 * fix: review fix, add common type * fix: typo * fix: remove await * fix: narrow the type instead of doing non null assertion
* fix: rename MAv2 type to mode, add 7702 middleware for react hook * fix: don't switch MintCard to MAv2 yet * fix: reconnect 7702 account after page refresh * chore: remove comment * docs: regen docs * fix: fix docs * fix: remove unnecessary optional chaining
adamegyed
force-pushed
the
adam/7702-core
branch
from
f6d209a to
bfc87e7
Compare
adamegyed
force-pushed
the
adam/7702-core
branch
from
bfc87e7 to
b3acd54
Compare
Pull Request Checklist
yarn test)sitefolder, and guidelines for updating/adding docs can be found in the contribution guide)feat!: breaking change)yarn lint:check) and fix any issues? (yarn lint:write)PR-Codex overview
This PR primarily updates the
viemdependency version across multiple packages and introduces new functionality related toModularAccountV2, including its creation, client handling, and error management.Detailed summary
viemfrom^2.20.0to^2.22.6in severalpackage.jsonfiles.ModularAccountV2in account creation and client functions.InvalidModularAccountV2Modeerror class.signAuthorizationmethod inLocalAccountSigner.ModularAccountV2methods.